Re: [evolution-patches] #53433 : Slider not changing the timeout value....
- From: Sivaiah N <snallagatla novell com>
- To: Chris Toshok <toshok ximian com>
- Cc: JP Rosevear <jpr ximian com>, evolution-patches lists ximian com, Hari Prasad Nadig <hp ndeepak info>
- Subject: Re: [evolution-patches] #53433 : Slider not changing the timeout value....
- Date: 02 Apr 2004 11:17:56 +0530
This patch changes the gui little bit (in terms of where the selected
time out value is displayed ) and also restricts user to select timeout
value in steps of minutes only (i.e user can not select one and half
minute as a timeout value). is it OK ?
Thanks,
Sivaiah
On Thu, 2004-04-01 at 13:40, Hari Prasad Nadig wrote:
> On Wed, 2004-03-31 at 09:22 -0500, JP Rosevear wrote:
> > On Tue, 2004-03-30 at 21:31, Chris Toshok wrote:
> > > patch looks fine to me.. just a few minor quibbles.
> > >
> > > this block could be axed entirely, as the blank line should stay and the
> > > top change is just addition of space at the end of the line:
> > >
> > > @@ -449,10 +457,9 @@
> > > GTK_MESSAGE_ERROR,
> > > GTK_BUTTONS_OK,
> > > _("Could not perform query on Root DSE"));
> > > - g_signal_connect (dialog, "response", G_CALLBACK(gtk_widget_destroy), NULL);
> > > + g_signal_connect (dialog, "response", G_CALLBACK(gtk_widget_destroy), NULL);
> > > gtk_widget_show (dialog);
> > > }
> > > -
> > > return ldap_error;
> > > }
> > >
> > >
> > > Also, this patch just fixes the UI - there are remaining issues in
> > > getting the timeout to be used in the backend.
> > >
> > > go ahead and commit with the above diff removed, and thanks for the
> > > patch :)
> >
> > I don't think he has commit privileges.
>
> yeah, true.. :)
>
> attached is the new diff.
>
> >
> > -JP
> > --
> > JP Rosevear <jpr ximian com>
> > Ximian, Inc.
> >
>
>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]