Re: [evolution-patches] #53433 : Slider not changing the timeout value....

[JP Rosevear <jpr ximian com>]

On Thu, 2004-04-01 at 03:10, Hari Prasad Nadig wrote:
> On Wed, 2004-03-31 at 09:22 -0500, JP Rosevear wrote:
> > On Tue, 2004-03-30 at 21:31, Chris Toshok wrote:
> > > patch looks fine to me..  just a few minor quibbles.
> > > 
> > > this block could be axed entirely, as the blank line should stay and the
> > > top change is just addition of space at the end of the line:
> > > 
> > > @@ -449,10 +457,9 @@
> > >  						 GTK_MESSAGE_ERROR,
> > >  						 GTK_BUTTONS_OK,
> > >  						 _("Could not perform query on Root DSE"));
> > > -		g_signal_connect (dialog, "response", G_CALLBACK(gtk_widget_destroy), NULL);
> > > +		g_signal_connect (dialog, "response", G_CALLBACK(gtk_widget_destroy), NULL);		
> > >  		gtk_widget_show (dialog);
> > >  	}
> > > -
> > >  	return ldap_error;
> > >  }
> > > 
> > > 
> > > Also, this patch just fixes the UI - there are remaining issues in
> > > getting the timeout to be used in the backend.
> > > 
> > > go ahead and commit with the above diff removed, and thanks for the
> > > patch :)
> > 
> > I don't think he has commit privileges.
> 
> yeah, true.. :)
> 
> attached is the new diff.

Committed.

-JP
-- 
JP Rosevear <jpr ximian com>
Ximian, Inc.