Re: [evolution-patches] Patch to enable cursor and keyboard navigation in mail reader,(v5), gconf version

[Radek Doulík <rodo ximian com>]

On Wed, 2003-06-25 at 10:17, yuedong du wrote:
> Attached wrong gtkhtml.diff, reattch and resend.
> 
> 
> Hi,
> 
> In this patch, a gconf key is added
> (/apps/evolution/mail/display/caret_mode). And a checkbox is added in
> the preference setting corresponding to the option. The code is in
> evolution.diff.
> 
> The attached pref.png is the screenshot, need Anna review?
> 
> At gtkhtml side, a new style property is also added. In the 'style-set'
> signal handler we change the gboolean var added into the htmlengine
> struct, and we use it to control whether to draw cusor. Other part is
> the same to previous patch.
> 
> I decide to remove the F7, because all other gconf key settings are
> handled by prefrence setting dialog. so I think we keep the processsing
> of gconf settings consistent, and not just mimic mozilla. So Radek and
> Ettore, you opinion?

I found f7 more handy than that. It's not different to other things as
you say, look at View/Message Display submenu. It's also persistant
across sessions and is in menu and not in settings.

It's just my opinion. I think Anna will tell us what's best from UI
perspective.

Radek

> 
> I have tested the patch.
> 
> 
> Regards
> York
> 
> On Sun, 2003-06-22 at 18:23, Radek Doulk wrote:
> > On Sat, 2003-06-21 at 17:21, Ettore Perazzoli wrote:
> > > On Fri, 2003-06-20 at 22:45, yuedong du wrote:
> > > > We agree to use F7 to enable caret mode.
> > > > 
> > > > But, what is the best form the option should be implemented as ? Global
> > > > variable or gconf ? Global variable means the setting will not be saved
> > > > after you exit evolution. A little inconvinience. 
> > > 
> > > I thought F7 was just supposed to work per-session?
> > 
> > mozilla remembers it for the next session, so it could make sense to
> > save it to gconf? I can imagine that user who want this feature would
> > like to have it enabled all the time.
> > 
> > I think this setting should be handled in evolution and set by gtkhtml
> > style property as fonts and other things?
> > 
> > cheers
> > Radek
> > 
> >