Re: [evolution-patches] patch review for crash bug

[Not Zed <notzed ximian com>]

No, its a bad url.

If '%%' is getting to url_decode, then its a bad url.  anything special like '%%' should be ENCODED when the url is created, so that url_decode will recfreate the original.

On Tue, 2003-12-02 at 18:18, Calvin Liu wrote:
> Hi, Not Zed,
>
> IMHO, that's a special user case, not a bad url.
>
> If you create a folder named "xxx$%^&", the url is there.
>
> The file "~/evolution/meta/_home_<uid>_evolution_vfolder/xxx$%^&" can't
> be created because it's incorrectly decoded in camel-url.c.
>
> After that, when you want to show the content of that folder, in file
> camel-vee-folder.c, function vee_search_by_expression, the function call
> "expr = g_strdup_printf ("(and %s %s)", vf->_expression_, _expression_);"
> will cause crash on Solaris. The vf->_expression_ is null here.
The meta file has nothing to do with the _expression_, so not opening that file is not the problem.  The expressions are all stored in vfolders.xml.

Something is creating a url without properly encoding the path in it.  It may just be something in camel-vee-store.c, but it is somewhere, and it is wrong.


> Thanks.
> Calvin
>
> On Tue, 2003-12-02 at 13:37, Not Zed wrote:
> > Hi Calvin,
> > 
> > Can you try to track down where these bad url's are coming from?  They
> > should never be created in the first place.
> > 
> > This workaround should fix a crash but wont fix the cause.  But i'll
> > commit it anyway.
> > 
> > Michael
> > 
> > On Tue, 2003-12-02 at 12:10, Calvin Liu wrote: 
> > > Aha, I just "grep" in source code and found the isxdigit. It's already
> > > there, great! :)
> > > 
> > > And I prefer to this one. So NotZed, please checkin the patch. It's
> > > important to Solaris build. 
> > > 
> > > Thank you very much!
> > > Calvin
> >