Re: [evolution-patches] patch review for crash bug

[Calvin Liu <calvin liu sun com>]

Hi, Not Zed,

IMHO, that's a special user case, not a bad url.

If you create a folder named "xxx$%^&", the url is there.

The file "~/evolution/meta/_home_<uid>_evolution_vfolder/xxx$%^&" can't
be created because it's incorrectly decoded in camel-url.c.

After that, when you want to show the content of that folder, in file
camel-vee-folder.c, function vee_search_by_expression, the function call
"expr = g_strdup_printf ("(and %s %s)", vf->expression, expression);"
will cause crash on Solaris. The vf->expression is null here.

Thanks.
Calvin

On Tue, 2003-12-02 at 13:37, Not Zed wrote:
> Hi Calvin,
> 
> Can you try to track down where these bad url's are coming from?  They
> should never be created in the first place.
> 
> This workaround should fix a crash but wont fix the cause.  But i'll
> commit it anyway.
> 
> Michael
> 
> On Tue, 2003-12-02 at 12:10, Calvin Liu wrote: 
> > Aha, I just "grep" in source code and found the isxdigit. It's already
> > there, great! :)
> > 
> > And I prefer to this one. So NotZed, please checkin the patch. It's
> > important to Solaris build. 
> > 
> > Thank you very much!
> > Calvin
>