Re: [evolution-patches] patch review for crash bug

[Jeffrey Stedfast <fejj ximian com>]

the proper fix would be to change:

if (*s == '%' && s[1] && s[2]) {

to

if (*s == '%') {
   if (isxdigit (s[1]) && isxdigit (s[2])) {
      *d++ = (XDIGIT (s[1]) << 4) + XDIGIT (s[2]);
      s += 2;
   } else {
      *d++ = *s;
      if (s[1] == '%')
        *d++ = *s++;
   }
} else
   *d++ = *s;

Jeff

On Mon, 2003-12-01 at 06:31, Calvin Liu wrote:
> Hi, there,
> 
> Here's a small patch to fix a crash bug.
> If you create vfolder like "xxx%%$$" it'll crash  on solaris or
> mis-displayed.
> Suppose we shouldn't decode for all "%xx" case, the "x" here should be
> {digital|a~z|A~z}.
> 
> Thanks.
> Calvin