Re: [evolution-patches] Seeking review for bug #47751 & #47752

[Not Zed <notzed ximian com>]

Well, I was hoping you would take my patch, and finish it.

The only other things that need fixing are a few dialogue's in
evolution/mail and perhaps evolution/composer that listen to the
response signal on the editor, since the patch will change some from
ACCEPT/REJECT to OK/CANCEL.

On Sat, 2003-08-23 at 21:20, Maxx Cao wrote:
> I think there should be no diffrence in using GTK_RESPONSE_ACCEPT or
> GTK_RESPONSE_OK, but
> anyway, the OK/OK pair gains better understanding than OK/ACCEPT,  :-)
> .
> 
> Shall I go on maintaining this patch or will you commit it directly?
> This patch should have fixed several
> Esc matters, at least 3 of the following:
>     1. add/edit filter
>     2. add/edit vfolder
>     3. add/edit saved search window
> 
> but have you noticed anywhere else that need fixing currently?
> Thanks.
> 
> Not Zed wrote:
> > BTW did you see the patch i did that did this and fixed other cases of
> > the same in the filter code?
> > 
> > There are also spots in the mailer that might also need fixing for this.
> > 
> > On Fri, 2003-08-22 at 02:15, Maxx Cao wrote:
> >   
> > > Hi Anna, Ettore and Jeff:
> > > 
> > > Thanks a lot for all your kindly help and comments. Especially for Anna, 
> > > you really taught me a lot, thank you!
> > > 
> > > So I make a summary here, for the principle of handling Esc key:
> > > 
> > > 1. For things like add/edit filters, Esc will close the dialog silently.
> > > 
> > > 2. For druid-like things (mail-config-druid, directory server druid ... 
> > > etc), a comfirmation message
> > >     will be given before canceling the druid, to prevent users from 
> > > losing their work by accident.
> > > 
> > > 3. The confirmation message will be like this:
> > >     "Are you sure you want to cancel this druid?"
> > >                                                                  ~~~~~ ( 
> > > or "wizard" is better wording for end users?)
> > > 
> > > 4. The codes which involves strings will only be commited to HEAD.
> > > 
> > > Yeah, as above, am I thinking it right?
> > > 
> > > Thanks Michael for your investigation on key binding of gtkdialog. I've 
> > > tried it and it works!
> > > 
> > > So the patch becomes very simple, please review. And if you feel OK 
> > > about my summary above, I'll
> > > go on working with the Esc handling of druids.
> > > 
> > > Thanks to all again! :-)
> > >     
> >   
> 
> -- 
> Best Regards
> Maxx