Re: [evolution-patches] Seeking review for bug #47751 & #47752

[Maxx Cao <maxx cao sun com>]

Hi Anna, Ettore and Jeff:

Thanks a lot for all your kindly help and comments. Especially for Anna, 
you really taught me a lot, thank you!

So I make a summary here, for the principle of handling Esc key:

1. For things like add/edit filters, Esc will close the dialog silently.

2. For druid-like things (mail-config-druid, directory server druid ... 
etc), a comfirmation message
   will be given before canceling the druid, to prevent users from 
losing their work by accident.

3. The confirmation message will be like this:
   "Are you sure you want to cancel this druid?"
                                                                ~~~~~ ( 
or "wizard" is better wording for end users?)

4. The codes which involves strings will only be commited to HEAD.

Yeah, as above, am I thinking it right?

Thanks Michael for your investigation on key binding of gtkdialog. I've 
tried it and it works!

So the patch becomes very simple, please review. And if you feel OK 
about my summary above, I'll
go on working with the Esc handling of druids.

Thanks to all again! :-)

--
Best Regards
Maxx

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/filter/ChangeLog,v
retrieving revision 1.373
diff -u -r1.373 ChangeLog
--- ChangeLog	5 Aug 2003 21:12:14 -0000	1.373
+++ ChangeLog	22 Aug 2003 06:07:11 -0000
@@ -1,3 +1,11 @@
+2003-08-22  Maxx Cao  <maxx cao sun com>
+
+	** See bug #47751 and #47752
+
+	* rule-editor.c (rule_add): Change GTK_RESPONSE_REJECT to 
+	GTK_RESPONSE_CANCEL, so that dialog closes on Esc key
+	(rule_edit): Same as above
+
 2003-08-05  Not Zed  <NotZed Ximian com>
 
 	** See bug #42636.
Index: rule-editor.c
===================================================================
RCS file: /cvs/gnome/evolution/filter/rule-editor.c,v
retrieving revision 1.54
diff -u -r1.54 rule-editor.c
--- rule-editor.c	29 Apr 2003 17:08:40 -0000	1.54
+++ rule-editor.c	22 Aug 2003 06:07:11 -0000
@@ -284,7 +284,7 @@
 	
 	re->dialog = gtk_dialog_new ();
 	gtk_dialog_add_buttons ((GtkDialog *) re->dialog,
-				GTK_STOCK_CANCEL, GTK_RESPONSE_REJECT,
+				GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
 				GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,
 				NULL);
 	
@@ -366,7 +366,7 @@
 	
 	re->dialog = gtk_dialog_new ();
 	gtk_dialog_add_buttons ((GtkDialog *) re->dialog,
-				GTK_STOCK_CANCEL, GTK_RESPONSE_REJECT,
+				GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
 				GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,
 				NULL);