Re: [Evolution] Bug 738247 - unwanted information disclosure in message headers

[d18jf98rw use startmail com]

Here is the patch

 diff -up evolution-data-server-3.24.6/src/camel/providers/smtp/camel-smtp-transport.c.orig 
evolution-data-server-3.24.6/src/camel/providers/smtp/camel-smtp-transport.c
--- evolution-data-server-3.24.6/src/camel/providers/smtp/camel-smtp-transport.c.orig   2017-09-27 
19:06:32.769883845 -0400
+++ evolution-data-server-3.24.6/src/camel/providers/smtp/camel-smtp-transport.c        2017-09-27 
19:09:50.902330428 -0400
@@ -1385,14 +1385,6 @@ smtp_helo (CamelSmtpTransport *transport
        address = g_inet_socket_address_get_address (
                G_INET_SOCKET_ADDRESS (transport->local_address));

-       name = g_resolver_lookup_by_address (
-               resolver, address, cancellable, &local_error);
-
-       /* Sanity check. */
-       g_return_val_if_fail (
-               ((name != NULL) && (local_error == NULL)) ||
-               ((name == NULL) && (local_error != NULL)), FALSE);
-
        if (g_error_matches (local_error, G_IO_ERROR, G_IO_ERROR_CANCELLED))
                return FALSE;

Now behavior became exactly the same as in thunderbird.
However I would prefer name variable to be assigned to return address domain name.
No recipient needs to know neither sender's workstation IP address nor its real host name.

Josh.

On Tuesday, September 26, 2017 11:41 AM, d18jf98rw use startmail com wrote:
 
> On Tuesday, September 26, 2017 10:31 AM, Milan Crha <mcrha redhat com>
> wrote:
>  
> > On Tue, 2017-09-26 at 09:53 -0400, d18jf98rw use startmail com wrote:
> > > Where is the function responsible for helo message?
> > Hi,
> > it's here:
> > https://git.gnome.org/browse/evolution-data-server/tree/src/camel/providers/smtp/camel-smtp-transport.c?h=gnome-3-24#n1388
> A piece of cake. Set name to NULL instead of g_resolver_lookup_by_address
> and let
> https://git.gnome.org/browse/evolution-data-server/tree/src/camel/providers/smtp/camel-smtp-transport.c?h=gnome-3-24#n1401
> fill in IP address. This will match thunderbird behavior.