Re: [Evolution] Image insertion bug?

[Matthew Barnes <mbarnes redhat com>]

On Thu, 2009-10-29 at 11:03 -0400, Art Alexion wrote:
> 1. Create an html message.
>      2. Insert an inline image from the toolbar Use a local image.
>      3. Delete the image from the message.
>      4. Edit (I cropped) the image in the Gimp or other photo editor.
>         Make sure to save the edits in the same place under the same
>         name.
>      5. Re-insert the image in the message
>
> The original, no longer existent image, is inserted.  Evo apparently
> caches the image and I don't see any way to refresh this cache to update
> to the edited version.
>
> That said, the edited image is the one that is sent.

Yes, it's a GtkHtml bug.

GtkHtml keeps an in-memory cache of images by URI, I guess to reduce
memory usage if the same image is used multiple times.  Each entry is
reference-counted, so when you deleted the image the reference count for
it -should- have dropped to zero and caused the cache entry to be
removed.

Looks like it's either not decrementing the reference count on deletion
or something else is still holding a reference.  So the cache entry is
not removed.  Then when you insert the modified image from the same URI,
GtkHtml says "oh, I already have this URI in my cache" and displays the
old image.

Evolution, OTOH, ignores GtkHtml's internal cache and reads the image
files for itself prior to encoding them for transport.

Matthew Barnes