[Evolution] [PATCH] evolution bug #16462



http://bugzilla.ximian.com/show_bug.cgi?id=16462 still not fixed in
1.0.3.  Please apply the below patch.  The patch has been stable for me
for weeks in evolution 1.0.2.  Apply with:

cd evolution-1.0.3      (toplevel source dir)
cp <patch location> ../
cat ../patch.evo-bug16462-1.0.3 | patch -p1

This bug is a major usability issue for people with touchpads and this
is the 2nd time I have submitted the patch.  I heard nothing the first
time, however I sent the patch in right before 1.0.3 was released, so I
understand you are busy.  Please advise if I need to do something
differently to get this patch in (or it least tell me if it is
rejected).

James Strandboge

PS-- See previous explanation below:

To fix bugg #16462, the patch makes the e_minicard_label_event() (in
addressbook/gui/widgets/e-minicard-label.c) handle the
GDK_BUTTON_PRESS
event properly.  Before, the e_minicard_label_event() would always
call
gtk_signal_emit_by_name with a GDK_BUTTON_PRESS, when in fact, it
should
only call gtk_signal_emit_by_name when the event was a single click
and
when the label did not have the focus yet.  Checking both of these
conditions fixes the mouse grab problem (you can now double, triple,
quadruple or more click and do massive random clicking all throughout
the minicard without it grabbing the mouse). 

The patch to fix the double middle mouse click grab is simply making
e_minicard_event() in e-minicard.c use only button 1 in the
GDK_BUTTON_PRESS processing, where before it would allow both. 
Otherwise, the behaviour for the middle mouse click is what the user
would expect (highlights the label, and pastes if the middle click
occured in the text).


-- 
Email:        jstrand1 rochester rr com
GPG/PGP ID:   26384A3A
Fingerprint:  D9FF DF4A 2D46 A353 A289  E8F5 AA75 DCBE 2638 4A3A

Attachment: patch.evo-bug16462-1.0.3
Description: Text Data

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]