Re: [Evolution-hackers] [PATCH] shell/e-convert-local-mail.c: Pass correct enum `e_account_find_t` to `e_account_list_find()`



Am Donnerstag, den 03.01.2013, 11:11 -0500 schrieb Matthew Barnes:
> On Thu, 2013-01-03 at 16:15 +0100, Paul Menzel wrote:
> > Date: Wed, 2 Jan 2013 12:16:50 +0100
> > 
> > Clang 3.2 reports the following warning.
> > 
> >         $ clang --version
> >         Debian clang version 3.2-9 (tags/RELEASE_32/final) (based on LLVM 3.2)
> >         $ CC=clang ./autogen.sh
> >         $ make
> >           CC     evolution-e-convert-local-mail.o
> >         e-convert-local-mail.c:275:37: warning: implicit conversion from enumeration type 'enum _e_account_item_t' to different enumeration type
> >               'e_account_find_t' (aka 'enum _e_account_find_t') [-Wconversion]
> >                 if (e_account_list_find (accounts, E_ACCOUNT_ID_ADDRESS, id)) {
> >                     ~~~~~~~~~~~~~~~~~~~            ^~~~~~~~~~~~~~~~~~~~
> >         1 warning generated.
> 
> You're on your own to patch that.
> 
> EAccount and EAccountList classes are gone in 3.6 and later.

Sorry, I missed to write that this is tested with 3.4.4 and I will try
to port those applicable to master later.

Could somebody please apply that to gnome-3-4? I have no commit access.
You do not have to do a release, but it would help distributors if such
patches would be applied upstream. GTK does the same. They probably will
not release another 3.4.x version but they still commit stuff to Git.


Thanks,

Paul

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]