Re: [Evolution-hackers] alarm-notify patch: Proposed changes to notify dialog

[Milan Crha <mcrha redhat com>]

On Thu, 2013-08-15 at 07:47 +0200, Thomas Mittelstaedt wrote:
> I made a couple of changes to my ancient (2.28.4) version of evolution.
> First, I encountered a nuisance in the alarm notify dialog, that when
> the dialog pops up and a new alarm is coming in, the selection changes
> to this new item, while the user potentially ist just clicking the
> dismiss or snooze button. I made the attached change to simply not
> preselect anything, having checked that the same is still running in the
> current git version at https://git.gnome.org/browse/evolution.

        Hi,
I made a little change to your proposal, and committed it as:
https://git.gnome.org/browse/evolution/commit/?id=daaf089be7ea1ac97a39ce6e38696be6851d3259

> I also had a crash in the alarm-notify app and I inserted the attached
> safety check.

I guess you face:
https://bugzilla.gnome.org/show_bug.cgi?id=641711
but I cannot tell for sure without a backtrace.

I cannot speak for the "ask before dismiss all" right now, I do not have
any strong opinion on it. The other clients do not ask too, which
doesn't mean it's a bad idea to add the confirmation dialog.

By the way, it's better to file bugs, as it's kind of a tracker and
things do not get lost there, like on mailing lists. See:
https://bugzilla.gnome.org/enter_bug.cgi?product=Evolution

        Bye,
        Milan