Re: [Evolution-hackers] Issues with new EBook dbus implementation

[Matthew Barnes <mbarnes redhat com>]

On Fri, 2011-05-27 at 16:49 +0200, Milan Crha wrote: 
> Maybe it can pump them, but it doesn't deliver them, as far as my tests
> showed, because they are usually delivered on idle, which never happen
> with blocked main loop. That's the reason why I added there this loop.
> Only notice that this loop is running for "sync" calls, and only if it's
> done from the main thread. The async calls and sync calls from a
> dedicated thread doesn't do any such thing. You may not use sync calls
> in your application, preferably. (Same as evolution shouldn't, which is
> subject to change, to use the EBOok/CalClient APIs directly.)

Can't we just consider it a programming error for a D-Bus method to be
called synchronously from the main thread?  I don't see any reason to
support this case since it would be by definition a bug.

In fact I'd go so far as to emit a runtime warning about it and return
immediately we detect that case.  Historically we've been not very good
about this sort of thing, and failing loudly might help flush out any
remaining blocking issues buried in Evolution or other parts of E-D-S.