Re: [Evolution-hackers] [PATCH 1/2] e_cal_new_system_foo() should create corresponding source in GConf

[David Woodhouse <dwmw2 infradead org>]

On Tue, 2011-05-10 at 10:19 +0200, Patrick Ohly wrote:
> It seems that a similar problem exists in libebook if no address books
> were created already by Evolution. Chris is seeing such an issue with
> 2.32.3 in MeeGo.

Oh, tits. I hate the fact that all this code is so *gratuitously*
separate. Because my patch ended up calling get_local_source() three
times (for cal/tasks/memos) I was tricked into thinking I'd already
covered everything; the fact that that was all still just *calendar* and
I hadn't handled the addressbook side had temporarily eluded my feeble
mind.

> We probably need to add the "create GConf entry for local:system" part
> to libebook in the gnome-2-32 branch. Is that something that is still
> of interest for Trunk, given that EClient API will obsolete it for
> 3.2?

It's still relevant for now, so let's do it. We *could* make a case for
not bothering, and just fixing it in 3.0 and 2.32 instead. But our
policy is to backport only fixes from master, and I prefer not to set a
counter-precedent unless I absolutely have to. It doesn't *hurt* to fix
it in master first.

Do you have a patch?

-- 
David Woodhouse                            Open Source Technology Centre
David Woodhouse intel com                              Intel Corporation