Re: [Evolution-hackers] edbus branch review ...

[Travis Reitter <treitter gmail com>]

Hi Michael,

Thanks for taking over here!

I briefly looked over (though didn't have time to carefully test) your
changes, and they seem good to me. Especially the added E/GDBus tests.
Very thorough.

As long as some one else can build this branch and have it pass basic
smoke testing, I'd be very happy to see this merged to mainline.

Regards,
-Travis

On Fri, Feb 26, 2010 at 2:31 PM, Michael Meeks <michael meeks novell com> wrote:
> Hi guys,
>
>        I have a new fun branch (to review for merging)
>
>        mmeeks-gdbus-import
>
>        So I am wickedly piling up other misc. fixes in there (so they don't
> mask other issues) - but I have the edbus code imported, and running -
> and, indeed, it seems to block rather less nastily than the dbus-glib
> variants[1]: which is all good.
>
>        It is essentially the work from origin/treitter-client-gdbus but adding
> the 'refresh' method, and of course porting it all to the internal copy
> of 'libedbus.so'.
>
>        This should let us stick with glib-2.28 (what I'm using), and yet get
> the benefits of moving closer to what gdbus will be in the end (I hope)
> - as well as the interactivity wins. I incorporate the fairly simple
> perl script I used to do the substitution in the first instance.
>
>        Why am I telling you this ? - I'd love some review of course; I've been
> playing with calendar & addressbook here for a bit; but would greatly
> appreciate some more input. Particularly since I didn't write the
> original gdbus port.
>
>        I'd also -really- like to get this in soonish;
>
>        Thoughts / flameage ? :-)
>
>        Thanks,
>
>                Michael.
>
> [1] - which seems to like blocking the mainloop any time any other
> thread does a synchronous call (not optimal).
> --
>  michael meeks novell com  <><, Pseudo Engineer, itinerant idiot
>
>