Re: [Evolution-hackers] improved rfc2047 decode patch

[Jeffrey Stedfast <fejj novell com>]

I noticed that the

while (camel_mime_is_dtext(*inptr) && *inptr)

got reversed in your camel-lite patch, which must mean that you had
locally changed the code to do the *inptr check first...

I think your change was correct, we should be checking *inptr first
before passing it to camel_mime_is_dtext(), so I've made that change to
upstream camel.

it likely won't make a difference, but it saves a few instructions by
avoiding an unnecessary lookup (*inptr can't be valid dtext if *inptr is
nul)

Also, you'll want to update camel-charset-map-private.h in your
camel-lite branch or the update to camel-charset-map.c doesn't actually
get you anything (that change is really only for auto-generating
camel-charset-map-private.h)

Which reminds me... I need to commit jacky's e-iconv change as well.

Jeff


On Wed, 2007-12-26 at 01:41 +0100, Philip Van Hoof wrote:
> Awesome! In the afternoon I started with the exact same port, but had to
> pause because of "family visiting", I'm back home and you have it
> finished :). Thanks a lot!
> 
> Brought it to tny's camel. FYI:
> http://tinymail.org/trac/tinymail/changeset/3203
> 
> 
> On Tue, 2007-12-25 at 19:28 -0500, Jeffrey Stedfast wrote:
> > This patch is a port of my GMime rfc2047 decoder which is even more
> > liberal in what it accepts than Thunderbird and is what I will be
> > committing to svn.
> > 
> > closing bugs:
> > 
> > #302991
> > #315513
> > #502178
> > 
> > Jeff
> > 
> > _______________________________________________
> > Evolution-hackers mailing list
> > Evolution-hackers gnome org
> > http://mail.gnome.org/mailman/listinfo/evolution-hackers