Re: [Evolution-hackers] Proposed fix for bug 311512

[Karl Relton <karllinuxtest relton ntlworld com>]

Hi friends,

Could anyone take a look at my proposed patches
for fixing bug 311512. Srini has had a look, and noted the ABI breakage
(see below). This was deliberate on my part - the only way to get
newmail notification to take note of the results of a filter thread.

Many thanks
Karl

On Fri, 2007-03-30 at 12:43 +0530, Srinivasa Ragavan wrote:
> On Fri, 2007-03-30 at 07:51 +0100, Karl Relton wrote:
> > Last week I posted two patches (one for eds, one for evo) on evo bugzill
> > that I believe fix bug 311512.
> 
> > --- camel-folder.h.110	2007-03-20 16:57:40.000000000 +0000
> > +++ camel-folder.h	2007-03-20 16:50:34.000000000 +0000
> > @@ -195,6 +195,7 @@ typedef struct {
> >  	void     (*freeze)    (CamelFolder *folder);
> >  	void     (*thaw)      (CamelFolder *folder);
> >  	gboolean (*is_frozen) (CamelFolder *folder);
> > +	int      (*get_filter_thread) (CamelFolder *folder);
> >  } CamelFolderClass;
> 
> On first look, I noticed that your patch has introduced an ABI break in
> CamelFolderClass. 
> 
> I'm sure that the mailer hackers would have a more closer look at it. 
> 
> Thanks for your friendly poke :-) 
> 
> -Srini.
> 
> > f
> > Could you take a look - any comments are welcome!
> >