Re: [Evolution-hackers] Re: component selection from menus was Re: [evolution-patches] 57653 & 57654 : toolbar and sidebar visibility

[Not Zed <notzed ximian com>]

"Silence is compliance".

I've committed this, with a few changes and fixups:

• memory leak of pixbuf xml
• i18n issues (the _attribute syntax is used for i18n stuff in files only)
• use proper icon size in menus
• minor (or major) code changes

I also put it in to a "Window" submenu of "View".  It kinda looked iffy otherwise, and I would presume that you would normally do it from the shortcuts anyway and don't need the clutter there (particularly since it could potentially be aribtrarily long).  If that presumption is wrong, it's easy to fix.  The "Window" label seemed better than "Component" but still doesn't seem 100% either *shrug*.


On Tue, 2004-05-18 at 11:19 +0800, Not Zed wrote:

Hi guys,

JPR asked me to look at

http://bugzilla.ximian.com/show_bug.cgi?id=55375

And this patch does just that.

Any objections?  I'm fairly happy with it as is, apart from some minor things (like g_utf8_get_char("-") rahter than just '-'.

Michael

On Thu, 2004-05-06 at 17:39 -0400, William Jon McCann wrote:

Hello Anna,

Anna M Dirks wrote:
> On Thu, 2004-05-06 at 00:12 -0400, William Jon McCann wrote:
>>I'm not sure putting them in a submenu is the way to go.  I think they 
>>should be in one of the toplevels but I don't have any strong opinions 
>>on which one.
> 
> So given that our UI is *supposed* to be frozen, I would very much like
> to make as few large changes to the Evo UI as possible. Adding a new
> toplevel menu is exactly the kind of very large change which I want to
> stay away from. 
 >
> To that end, in keeping with the HIG, these items should be in the
> "View" menu. The HIG goes as far as to stipulate that every app with a
> toolbar should have a "Toolbar" menuitem, placed *in* the View menu. To
> put it anywhere else would be to make ourselves inconsistent with the
> rest of GNOME.

Ok.  I'm not sure what the toolbar toggle has to do with this exactly 
except that the component buttons are certainly a type of toolbar. 
Therefore, they should have equivalent menu items.

I have updated the patch to move these items to the View menu.

Thanks,
Jon

Michael Zucchi <notzed ximian com> Ximian Evolution and Free Software Developer

Novell, Inc.

Michael Zucchi <notzed ximian com> Ximian Evolution and Free Software Developer

Novell, Inc.