Re: [Evolution-hackers] mark junk/not junk problem
- From: Radek Doulík <rodo ximian com>
- To: Not Zed <notzed ximian com>
- Cc: evolution-hackers ximian com
- Subject: Re: [Evolution-hackers] mark junk/not junk problem
- Date: Thu, 11 Mar 2004 13:31:01 +0100
On Thu, 2004-03-11 at 18:04 +0800, Not Zed wrote:
> > > Anyway I had a thought while i couldn't get to sleep last night, which
> > > should hopefully be acceptable to you, because it:
> > > - simplifies the api to simply setting or unsetting bits on the
> > > messageinfo
> > > - applies the learner asynchronously, but as soon as possible
> >
> > that sounds good
> >
> > > In camel-folder.c:folder_changed
> > > - add another bit to camelmessageinfo for 'learned' stuff,
> > > - add a check for changed uid's that change the junk status
> > > - add these uid's to the existing filter_folder structure and fire off
> > > the existing filter folder code. you probably need 2 lists, one for
> > > stuff to mark as junk and one for stuff to mark as not junk
> > > In camel-folder.c:filter_filter
> > > - if there are junk messages, set/unset the junk status
> > > - if there is anything to filter, filter it
> > > In camel-folder.c:camel_folder_set_message_flags
> > > - if you're setting or unsetting the junk status, and the learned bit
> > > isn't being set too, then clear the learned bit.
> >
> > I don't understand parts of it so I will look at the code and ask you on
> > irc. I didn't sleep very well either. It's a pity we didn't solve it
>
> It should be pretty obvious to see from the code once you get in there.
> Its essentially but not quite exactly the same way imap filtering works.
> And there's only a couple of places you need to add any code. And you
> can get rid of all the stuff in mail-ops.c
>
> I wont be on tonight, jeff should be able to help if required, but it
> shouldn't be needed.
OK. I will try to cook the patch and send it to review before
committing.
Radek
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]