Re: [Evolution-hackers] Question about "MODEL_CELL_CHANGED" signal of ETableModel

[Eric Zhao <eric zhao sun com>]

In both of the two functions, the col and row are used directly, and 
cause wrong results, so it's necessary to change them. Thanks!

Regards,
Eric

Not Zed wrote:

> It might not matter, if for example the row/col values aren't actually 
> used in that function, or they are just passed on to another function 
> or signal in the same order.
>
> I would say, if you need to use it for anything, treat it as col, 
> row.  And if there are bugs in the code they can be fixed up.
>
> On Thu, 2004-07-22 at 20:33 +0800, Eric Zhao wrote:
>
> > Hi,
> >     I'm using "MODEL_CELL_CHANGED" signal in the a11y implementation 
> > of e-table. But I got confused about the prototype of the 
> > "MODEL_CELL_CHANGED" singal's handler.
> >
> > Accordind to e-table-model.[h,c], it should be * (ETableModel *etm, 
> > int col, int row)*;
> > e-table-model.h:
> >
> >        void        (*model_cell_changed)  (ETableModel *etm, int col, int row);
> >    
> >
> > e-table-model.c:512:
> >
> >        g_signal_emit (G_OBJECT (e_table_model),
> >                       e_table_model_signals [MODEL_CELL_CHANGED], 0, col, row);
> >    
> >
> >
> > But some other sources use *(ETableModel *etm, int row, int col)* as 
> > the prototype, eg.:
> > *e-table-subset.c:366:*
> >
> > etss_proxy_model_cell_changed (ETableModel *etm, int row, int col, ETableSubset *etss)
> >    
> >
> > *gal-a11y-e-cell-toggle.c:102*
> >
> > model_change_cb (ETableModel *etm,
> > 		 gint row,
> > 		 gint col,
> > 		 GalA11yECell *cell)
> >    
> >
> >
> > It seems that the last two cases are wrong, aren't they?
> >
> > Thanks!
> > Eric
> >
> > --
> > Eric Zhao <eric zhao sun com> <mailto:eric zhao sun com>
> >
> > Public Key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE3225516 <http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE3225516>
> > Key fingerprint = EA12 D205 D359 A98D E63E  CAC3 C2A7 30B1 E322 5516
> >    
> --
> 	*Michael Zucchi* <notzed ximian com <mailto:notzed ximian com>>
> /"born to die, live to work, it's all downhill from here"/
> Novell's Evolution <http://codeblogs.ximian.com/blogs/evolution/> and 
> Free Software <http://www.gnu.org/philosophy/free-sw.html> Developer


--
Eric Zhao <eric zhao sun com>

Public Key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE3225516
Key fingerprint = EA12 D205 D359 A98D E63E  CAC3 C2A7 30B1 E322 5516