Re: [evince] Added New Functionalities + Some TODOs

[Arshad Husain <arshad husain1 gmail com>]

In terms of the icons, the strikeout and underline icons were taken directly from the gnome-scalable-actions folder, turned to black, slightly enlarged, and converted from .svg to .png (I'm pretty sure it's .png). All the other icons were taken from the gnome scalable icons folder and modified to provide a better description of the annotation action. 

On Thursday, July 14, 2016, jose aliste gmail com <jose aliste gmail com> wrote:

Arshad, this is nice work. It needs more reworking before we can try to merge this, but it is along the lines I think we want to make evince to go. One particular issue is whether you designed the icons or used icons from other parties. The icons look to me very similar to the icons in Preview.app in MacOS.

Greetings

José

On Thu, Jul 14, 2016 at 2:17 AM, Arshad Husain <arshad husain1 gmail com> wrote:

PLEASE NOTE: Sorry for the double message. I forgot to cc evince-list.

Here is my branch of evince.

https://github.com/husain3/evince

Please note: My last push is me working on getting undo functionality to work for text annotation changes as well.

I'm not too sure if it's buildable on other machines. It builds fine on my computer.

Also, let me know what you think about the new icons. I could possibly try and match the color of the icons to the ones on the main toolbar. Also, let me know what you think about the new icons. I could possibly try and match the color of the icons to the ones on the main toolbar.

On Tue, Jul 12, 2016 at 12:25 PM, jose aliste gmail com <jose aliste gmail com> wrote:

Hi,

I hit the send button too quickly. I mean, all of this is great!!! And we thank the time you have spent coding this, but please share so we can integrate your patches into the main branch.

Greetings

José

On Tue, Jul 12, 2016 at 3:24 PM, jose aliste gmail com <jose aliste gmail com> wrote:

where is the code? Please sufmit patches so we can review them or at least point us to where your fork lives

On Sat, Jul 9, 2016 at 6:14 PM, Arshad Husain <arshad husain1 gmail com> wrote:

Hello,

I've added the ability for Evince to: 

- underline 

- strike-through

- choose between different annotation colors.

- designed and implemented new and more relevant icons (based off of gnome scalable icons) for annotations toolbar

I've also made a few refinements to annotation features:

- Not showing annotation tooltips on all types of annotations if comment is either empty or all whitespace. 

My immediate TODOs:

- Create undo function (if not already implemented) or improve undo function.

- Convert PS files to PDF format for viewing/annotating (PS reader problematic; let's discuss). Apple's Preview converts PS to PDF for viewing/annotating. 

- General bug fixing of my additions.

I still have to make sure that my fork of evince will run on another computer. I'm looking forward to working with all of you.

Thanks,

Arshad Husain

_______________________________________________
evince-list mailing list
evince-list gnome org
https://mail.gnome.org/mailman/listinfo/evince-list