Re: document_save question



Hi Nickolay,

On 12/22/05, Nickolay V. Shmyrev <nshmyrev yandex ru> wrote:
В Чтв, 22/12/2005 в 00:21 +0200, Jani Monoses пишет:
>
> Hello
>
> it looks like the various backends than now implement save could use
> a factoring of what is common in that vfs-using function.  It does not
> seem
> to matter what kind of document it is, as the saving deals with
> URI's.
> So if I am not mistaken a function could be made in a common file and
> the backends
> wrap it and just pass the URI to be saved ( DVI_DOCUMENT
> (document)->uri) ,thus the backends
> won't each depend on gnome-vfs. I admit I am working again on getting
> a minimal patch against evince 0.5.0
> to build it --without-gnome ;). But whatever seems sensible for the
> official code base too I'd like to get incorporated
> if possible
>
> thanks
> Jani

Well, Jani, it would be nice to make this function common for all
backends somehow. It surely should stay there still, since we are going
to implement writing of PDF annotations in the future. But this fix
certainly has low priority.

Is is because of the pdf annotations feature  that currently the pdf backend
uses a separate save function path? I assume it is historical too because saving is done
by poppler in the PDF case , but why was it not switched to a gnome-vfs backed save_document?

We have much more important problems like this one for example:

http://bugzilla.gnome.org/show_bug.cgi?id=318568

Bug 318568 ? doesn't handle %%Orientation: Landscape


I see that the ps backend correctly sets the orientation, it is only the frontend that does
not take it into account right? I wonder if this was checked on document (or per page) load it could
mimic a user triggered rotation of the image? I am not (yet) familiar enough with the source to
see if this is a feasible solution.
 
Jani


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]