Summary for patch h6

[Peter Harvey <pah06 uow edu au>]

This is a summary of the changes in patch h6. It may be incomplete or
erroneous (great...) but should at least provide an overview of what
this patch does at the source code level.

I have marked points as "NEW FOR H6" if these are things which have been
added recently (as opposed to other points, which are generally just
repeats of what I said in my last email for h4). I have tried to sort
the changes by order of importance and/or most recent.

Peter.

----------------------------------

src/bookmarks/ephy-bookmarks-ui.c
src/bookmarks/ephy-bookmarks-ui.h
      * NEW FOR H6: Contains signal handlers which listen to changes in
        the bookmarks database and erase the bookmarks menu for each
        EphyWindow.
      * NEW FOR H6: No longer updates actions (they are self-updating)
        nor maintains the action group (it is self-maintaining too).
      * NEW FOR H6: Keeps an g_string which contains the shared XML used
        to generate the bookmarks menu and favourites menu. Constructs
        this string only when necessary. Uses ephy_bookmarks_menu_build
        to create the string.
      * Contains signal handlers for various menu actions to ensure that
        the bookmarks menu is rebuilt just-in-time.
      * Contains signal handlers which are used to correctly read and
        write bookmark/topic entries in the toolbars XML.
      * Contains functions to attach the above signal handlers to the
        bookmarks database and the toolbar model.

src/bookmarks/ephy-bookmarks-menu.c
src/bookmarks/ephy-bookmarks-menu.h
      * NEW FOR H6: Builds a bookmarks menu by generating the XML string
        which can be passed to GtkUIManager. Allows for sharing of the
        generated menu between multiple windows.
      * No longer maintains the bookmarks menu (this is the job of ephy-
        bookmarks-ui).

src/bookmarks/ephy-bookmark-action.c
src/bookmarks/ephy-bookmark-action.h
src/bookmarks/ephy-topic-action.c
src/bookmarks/ephy-topic-action.h
      * NEW FOR H6: Added functions to create action groups which
        automatically update themselves when a bookmark/topic is
        added/removed. Very clean.
      * NEW FOR H6: Each action keeps itself up to date with changes in
        it's node. It does this via the EPHY_NODE_CHANGED signal.
      * Each action now has a pointer to the EphyNode which is being
        represented, and the EphyWindow which is the target of any
        activity. This is instead of keeping the node id.
      * Removed all signals and replaced with builtin behaviours.
      * Reworked code to handle interaction with the toolbar model. 
      * Removed drag-and-drop for the topic action. Have left it in for
        bookmark actions, but would like to remove it if noone uses it.
      * Removed checks which test if the widget is on the bookmarks bar.
      * Simplified property management by removing separate functions
        for different properties.
      * Removed signal handlers which received events from
        bookmarks/topics. This is now handled by the signal handlers in
        ephy-bookmarks-ui.
      * Added functions to get the standard names of actions (OpenTopic
        and OpenBmk).
      * Replaced menu generation code for topic actions with a call to
        ephy_bookmarks_menu_build.

lib/ephy-node.c
lib/ephy-node.h
      * NEW FOR H6: Added EPHY_NODE_CHANGED signal.
      * NEW FOR H6: Added fix for ephy-node/object dispose bug.


src/ephy-toolbars-model.c
      * NEW FOR H6: Modified to accept drag-and-drop of things other
        than toolbar items.

data/ui/epiphany-bookmark-editor-ui.xml
data/ui/epiphany-ui.xml
      * NEW FOR H6: Removed the bookmarks bar menu items.

src/window-commands.c
      * NEW FOR H6: Removed all references to the bookmarks menu and
        favourites menu.

src/bookmarks/ephy-nodes-cover.c
src/bookmarks/ephy-nodes-cover.h
      * NEW FOR H6: Cleaned up a little. Should now run fractionally
        faster as it does lazy updating of the count_u array.

src/ephy-window.c
src/ephy-window.h
      * Removed all references to the bookmarks menu and favourites
        menu. Added call to ephy_bookmarks_ui_attach_window instead.

src/bookmarks/ephy-bookmarks-editor.c
src/bookmarks/ephy-bookmark-properties.c
src/bookmarks/ephy-bookmarks.c
src/bookmarks/ephy-bookmarks.h
      * Removed all references to the bookmarks bar.

lib/widgets/ephy-node-view.c
lib/widgets/ephy-node-view.h
src/bookmarks/ephy-topics-selector.c
      * Added code to provide 'markers' (part of my bookmarks menu
        patch).

src/ephy-shell.c
      * Code to create the bookmarks bar was removed. It was replaced
        with a single call to ephy_bookmarks_ui_attach_toolbar_model
        which installs signal handlers giving the same functionality as
        the bookmarks bar.

lib/egg/egg-editable-toolbar.c
lib/egg/egg-toolbar-editor.c
lib/egg/egg-toolbar-editor.h
      * Whitespace and other crap changes. Will backout later.