Re: Using icon theme icons

["David Adam Bordoley" <bordoley msu edu>]

mpeseng tin it writes: 

> I'm trying to use as much as possible icon theme icons instead of our own.
> Here are the remaining: 
>
> #define EPHY_STOCK_SECURE          "epiphany-secure"
> #define EPHY_STOCK_UNSECURE        "epiphany-unsecure"
> #define EPHY_STOCK_HISTORY         "epiphany-history" 
>
> All these seem to be generic enough to add them to gnome-icon-theme. 
>
> #define EPHY_STOCK_BOOKMARKS       "epiphany-bookmarks"

I think this should be added to gnome icon theme as well imo. There is a 
difference between "add bookmark" and "Bookmarks." We need both. 

> #define EPHY_STOCK_BOOKMARK_PAGE   "epiphany-bookmark-page" 

Seriously this is the worst icon ever. I just took a kde icon, changed the 
colors and did some gimp magic. I had/have no clue what the hell I was doing 
and you think we should actually keep it :P 

> There are add_bookmark, edit_bookmark icons in gnome-icon-theme now.


> http://cvs.gnome.org/lxr/source/gnome-icon-theme/24x24/stock/object/stock_add-bookmark.png
> http://cvs.gnome.org/lxr/source/gnome-icon-theme/24x24/stock/object/stock_edit-bookmark.png 
>
> Though they dont  seem as clear as the current ones to me (they are themable
> but the default is important ...). Also for the BOOKMARKS one, epiphany

The add bookmarks one is ok. Totally unrelated but i still think we should 
change the bookmarks menu to be a short list (12-15 items) of the most used 
bookmarks along with a "more bookmarks..." menu item that opens the 
bookmarks window proper. But no need to start a flame war or anything :P 



> case is  a bit special because we would have to use it also as desktop icon
> item.

As above I think we should just add the current bookmarks icon to 
gnome-icon-theme. 

> #define EPHY_STOCK_ENTRY           "epiphany-entry"
> #define EPHY_STOCK_DOWNLOAD        "epiphany-download" 
>
> These are probably epiphany specific. Well maybe download could be proposed

ephy-download is probably ok to add to gnome icon theme. A few other apps 
support downloading and this is just another jimmac creation so it should 
fit in fine with gnome icon theme. 

ephy-entry is just another one of my hacked icons for the toolbar. Its' not 
even correct anymore as it doesn't actually represent what the toolbar item 
lookslike. if i have time to fix it i will, probably won't until christmas 
time though :/ 

> for gnome-icon-theme if there are other possible users (download manager
> ?). 
>
> Opinions ? Especially about the bookmarks icons thing ... 
>
> Marco 
>
> P.S. I had just losed the whole mail, luckily Dave convinced me to implement
> undo ;) 

Did i mention that this is one of the best ephy *features* ever. 

dave