Re: wrote EOG plugin: exif display

[Felix Riemann <friemann svn gnome org>]

Am Sonntag, den 24.05.2009, 20:48 +0200 schrieb Emmanuel Touzery:
> Hello,
> 
Hi,

>      I wrote a new plugin for EOG: exif display (in C).
> 
>      It displays the most important EXIF info in the sidebar and 
> optionally in the status bar and shows in the sidebar per-channel or RGB 
> histogram for the current picture.
> 
>      I put a screenshot there:
> http://www2.arnes.si/~shvali/exif-display-screenshot.png
> 

Looks pretty nice. :-)
The histogram is really neat eye-candy and the Exif data could be of use
to the people dooming the image properties dialog.

>      And the source code is there:
> http://www2.arnes.si/~shvali/exif-display.zip
> 

The tarball seems to be missing the GtkBuilder files (*.ui).

>      I wonder if you'd be interested to take this plugin in that git 
> repository or somewhere else so that also others could use it. I think 
> it's useful for people who care about digital photography, and it would 
> get a much wider audience if it's in the main EOG repository.
> 

Sure, we can put it into eog-plugins. We haven't managed to do a release
of it yet, but we hopefully do during summer.

>      There are probably some problems with the code also, I'm interested 
> if you notice any.
> 
I haven't looked at the code in detail yet, but I found this build
system related issue:

After checking for libexif you substitute the wrong variables:

> +
> +    PKG_CHECK_MODULES(EXIFDISPLAY,
> +        [ libexif >= 0.6.16 ],
> +        [],[have_exifdisplay=no])
> +    AC_SUBST(CHAMPLAIN_LIBS)
> +    AC_SUBST(CHAMPLAIN_CFLAGS)

You probably want to subst EXIFDISPLAY_LIBS and EXIFDISPLAY_CFLAGS here.
(Good old copy&paste ;-) )

Then you need to use them, as the installed eog might not necessarily be
linked against libexif (and thus doesn't carry it as a dependency). To
avoid build errors in that case, you need to include these two variables
in your plugins CFLAGS and LIBADD sections.

You might also want to extend the plugin's description in the desktop
file as currently it's not really informative. Just give some hint about
what the plugin does.

Besides I'm eager to see it in action. :-)

Regards,

Felix