Re: [Ekiga-list] compile error ekiga 3.2.5 / xcap module

[Eugen Dedu <Eugen Dedu pu-pm univ-fcomte fr>]

Julien Puydt wrote:
> Dominique Leuenberger a écrit :
> > > > > On 8/25/2009 at 14:19, Julien Puydt <jpuydt free fr> wrote: 
> > > > If you commit it, can you please let me know the commit id?
> > > http://git.gnome.org/cgit/ekiga/commit/?id=5395e4741076ece219f0aa1710a4fc589 
> > >
> > > a7269b7
> >
> > Thank you very much! Glad this could be resolved.
> >
> > I ad to apply a 2nd patch to the code base, as the brp checks of 
> > openSUSE complained about 'reached end of non void function without 
> > return value'.
> > Find the patch attached for your information (warning: might be 
> > completely wrong).
>
> Fixed too (notice that return NULL would give a segfault since a 
> std::string can't be built from NULL -- fortunately that code shouldn't 
> ever run).

Then maybe put a g_warn_if_fail before the return, so that we do not 
miss this error if it appears?

--
Eugen