Re: [Ekiga-devel-list] pixmap package name



On 06/02/14 21:42, Eugen Dedu wrote:
On 01/02/14 17:09, Damien Sandras wrote:
Le 26/01/14 19:58, Eugen Dedu a écrit :
On 25/01/14 16:06, Damien Sandras wrote:
Le 25/01/14 15:22, Eugen Dedu a écrit :
On 25/01/14 14:45, Damien Sandras wrote:
Le 23/01/14 14:04, Eugen Dedu a écrit :
In pixmaps/Makefile.am, the word ekiga is used twice. Shouldn't
PACKAGE_NAME
be used instead?

You can change it if you prefer.

In order to have both stable and unstable packages on my machine, I
change the
name to ekiga-snapshot.  The modification I proposed should help,
in my
opinion.  I will do it.

I have just done it.

I think there is an error in pixmap/Makefile.am file:

IMAGES_FILES= \
[...]
inlines.h: $(IMAGE_FILES) $(nobase_dist_icon_DATA) Makefile.am

Shouldn't the last line use IMAGES_FILES instead of IMAGE_FILES?
There is no
other IMAGE_FILES in whole ekiga code.

Yes, but it raises the question : is inlines.h still used at all ?

I think not...

It is used in lib/gui/gmstockicons.c.

Fixed (and tested) with https://git.gnome.org/browse/ekiga/commit/?id=ca309540b471.

--
Eugen


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]