[Ekiga-devel-list] [Fwd: [PATCH] Opal: SRTP: No AVP/UDPTL "formats" mentioned in RFC but introduced in rtp.h ? build errors]

[thomas schorpp <thomas schorpp googlemail com>]

-attachments-

--- Begin Message ---

• From: thomas schorpp <thomas schorpp googlemail com>
• To: opalvoip-devel lists sourceforge net
• Subject: [PATCH] Opal: SRTP: No AVP/UDPTL "formats" mentioned in RFC but introduced in rtp.h ? build errors
• Date: Tue, 03 Jun 2008 02:46:19 +0200

hi, pls check this out:

schorpp tom1:/usr/local/src/opal$ dpkg -l *srtp*
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Cfg-files/Unpacked/Failed-cfg/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Hold/Reinst-required/X=both-problems (Status,Err: uppercase=bad)
||/ Name                     Version                  Beschreibung
+++-========================-========================-================================================================
un  libsrtp-dev              <keine>                  (keine Beschreibung vorhanden)
ii  libsrtp1-dev             1.4.4~dfsg-2             Secure RTP (SRTP) and UST Reference Implementations - developmen
ii  srtp-docs                1.4.4~dfsg-2             Secure RTP (SRTP) and UST Reference Implementations - documentat
ii  srtp-utils               1.4.4~dfsg-2             Secure RTP (SRTP) and UST Reference Implementations - utilities

g++ -DPTRACING=1 -D_REENTRANT -fno-exceptions  -Wall  -DP_64BIT -fPIC -DPIC -DNDEBUG -I/usr/local/src/opal/include  -I/usr/local/src/opal/../ptlib/include -Os    -c /usr/local/src/opal/src/rtp/srtp.cxx -o /usr/local/src/opal/lib/obj_linux_x86_64_r/srtp.o
/usr/local/src/opal/src/rtp/srtp.cxx: In constructor 'OpalSRTP_UDP::OpalSRTP_UDP(unsigned int, PBoolean)':
/usr/local/src/opal/src/rtp/srtp.cxx:67: error: no matching function for call to 'SecureRTP_UDP::SecureRTP_UDP(unsigned int&, PBoolean&)'
/usr/local/src/opal/include/rtp/rtp.h:1128: note: candidates are: SecureRTP_UDP::SecureRTP_UDP(const PString&, unsigned int, PBoolean)
/usr/local/src/opal/include/rtp/rtp.h:1114: note:                 SecureRTP_UDP::SecureRTP_UDP(const SecureRTP_UDP&)
make[1]: *** [/usr/local/src/opal/lib/obj_linux_x86_64_r/srtp.o] Fehler 1
make[1]: Leaving directory `/usr/local/src/opal'
make: *** [optshared] Fehler 2

schorpp tom1:/usr/local/src/opal$

   SecureRTP_UDP(const PString & format, <----

cannot see the need or even a encapsulation spec for such formats in http://www.packetizer.com/rfc/rfc3711/

adding overload to Type SecureRTP_UDP in header, patch attached, compiles now (but will that run?)

but opal .so will not link libsrtp.a from debian (license conflict?):

-lsrtp -lldap -llber -lldap_r  -lpthread -lssl -lcrypto -lexpat -lSDL -lresolv -ldl
/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/4.2.4/../../../../lib/libsrtp.a(srtp.o): relocation R_X86_64_32 against `mod_srtp' can not be used when making a shared object; recompile with -fPIC
/usr/lib/gcc/x86_64-linux-gnu/4.2.4/../../../../lib/libsrtp.a: could not read symbols: Bad value
collect2: ld returned 1 exit status
make[1]: *** [/usr/local/src/opal/lib/libopal_linux_x86_64_d.so.3.3-beta0]

srtp.o is build right:

g++ -DPTRACING=1 -D_REENTRANT -fno-exceptions  -Wall  -DP_64BIT -fPIC -DPIC -g -D_DEBUG -I/usr/local/src/opal/include  -I/usr/local/src/opal/../ptlib/include    -c /usr/local/src/opal/src/rtp/srtp.cxx -o /usr/local/src/opal/lib/obj_linux_x86_64_d/srtp.o

seems not to be build with -fPIC, reporting bug.

y
tom

Index: include/rtp/rtp.h
===================================================================
--- include/rtp/rtp.h	(Revision 20359)
+++ include/rtp/rtp.h	(Arbeitskopie)
@@ -1119,6 +1119,14 @@
   //@{
     /**Create a new RTP channel.
      */
+    SecureRTP_UDP(
+#if OPAL_RTP_AGGREGATE
+      PHandleAggregator * aggregator, ///< RTP aggregator
+#endif
+      unsigned id,                    ///<  Session ID for RTP channel
+      PBoolean remoteIsNAT                ///<  PTrue is remote is behind NAT
+    );
+
     SecureRTP_UDP(const PString & format,
 #if OPAL_RTP_AGGREGATE
       PHandleAggregator * aggregator, ///< RTP aggregator

--- End Message ---