Re: [Ekiga-devel-list] Patch

[Damien Sandras <dsandras seconix com>]

Hi Matthias,

Le lundi 05 f�ier 2007 �2:34 +0100, Damien Sandras a �it :
> Hi Mathias,
> 
> 
> I am finally reviewing your patch to commit it.
> 
> I noticed that a few functions contained GTK+ calls which were not
> protected around gnomemeeting_threads_enter/gnomemeeting_threads_leave.
> That's required due to the fact that GTK+ is not thread-safe (X is not
> thread-safe either).
> 

I was wrong, unprotected functions are protected when being called.


> You are using XV calls in functions without protecting them around
> gnomemeeting_threads_enter/leave
> 
> So I have 2 questions :
> - was your patch crashing Ekiga or not ?
> - is XV thread-safe or not ?
> 
> Thanks !
-- 
 _      Damien Sandras
(o-      
//\    Ekiga Softphone : http://www.ekiga.org/
v_/_  NOVACOM                 : http://www.novacom.be/
          FOSDEM                   : http://www.fosdem.org/
          SIP Phone             : sip:dsandras ekiga net