Re: Two Patches to fix some Compiler Warnings



Hi Andreas

On 2014-07-07 17:00, Andreas Winkelmann <ml awinkelmann de> wrote:
On Monday 07 July 2014 15:21:04 David King wrote:
For the second patch, I think that can be improved beyond just removing
the warning, and that refactoring Id3tag_Get_Field() and
Id3tag_Set_Field() would be the best option.
…

Yes, the "9999" looks ugly somehow. But I cannot judge. Surely there was a
reason for inserting this. With my patch I have tried to go the way with the
lowest risk breaking something ;-)

I will try to look at this to get rid of the "9999" ;-)

When merging the wip/application-window branch to master, I included a patch which avoids these compiler warnings. The functions in question could still benefit from some refactoring, however.

--
http://amigadave.com/

Attachment: signature.asc
Description: Digital signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]