Hi Andreas On 2014-07-07 14:38, Andreas Winkelmann <ml awinkelmann de> wrote:
Attached are two patches to fix some Compiler Warnings. Now there are no warnings left ;-)
Thanks!For the first patch, it seems that this is due to a openSUSE-specific patch:
https://build.opensuse.org/package/view_file/openSUSE:13.1/libid3tag/libid3tag-0.15.1b-mb.diff?expand=1I am not aware of any other distributions that apply that patch, so I will not apply the fix at the moment. If you are concerned about the warning, it would be best to apply a similar patch to EasyTAG locally.
For the second patch, I think that can be improved beyond just removing the warning, and that refactoring Id3tag_Get_Field() and Id3tag_Set_Field() would be the best option.
Looking at the checks in those functions, it seems that it would be possible to eliminate the extra 9999 value if the check for a non-standard encoding was done first, and the other checks were done later with the existing switch/case statements. It would be great if you could make my suggested changes, but I would be happy to have a look otherwise.
-- http://amigadave.com/
Attachment:
signature.asc
Description: Digital signature