Hi Tony On 2013-08-18 22:33, Tony Young <tony rfw name> wrote:
On Sun, Aug 18, 2013 at 9:23 PM, David King <amigadave amigadave com> wrote:That does not seem to be true, as the GtkApplication documentation shows Mac OS X menu integration: https://developer.gnome.org/gtk3/stable/GtkApplication.html#GtkApplication.description Presumably, the GTK+ application menu is used as the menu structure for the application menu in OS X.Ah, I wasn't aware of that. I've mostly been looking at the GtkosxApplication documentation[1] which doesn't mention anything about GtkApplication. I'll take a look into it -- I haven't really worked with GTK before and I just wanted to get something running natively on OS X, so sorry for all the futzing around!
I think that with GtkApplication, it might be possible to avoid ifdefs entirely, although I am not sure about the Help menu.
Note that only GTK+ 3.4 and above has GtkApplication support, and if switching EasyTAG to use GTK+ 3 only, I think that GTK+ 3.4 should be the target, as that is the GTK+ version in Debian stable. EasyTAG 2.1.9 (the next release) will still be compatible with GTK+ 2, so it might be best to experiment with GTK+ 3 porting in a branch, with a view to switching to GTK+ 3 only after 2.1.9 has been released.
As I said previously, I am happy to do most of the GTK+ 3 porting work, especially the more invasive GAction and GMenu changes, as I am quite familiar with the changes that are required. For some background reading, there is a guide of the concepts and some implementation examples on the GNOME wiki:
https://wiki.gnome.org/HowDoI/ApplicationMenu -- http://amigadave.com/
Attachment:
signature.asc
Description: Digital signature