[Easytag-mailing] Re: [PATCH] bug when saving unsupported tags in flac comments

[Jérôme COUDERC <easytag gmail com>]

Hi Mark,

And thanks for the patch applied to my current sources

Jerome


Mark Ferry wrote, the 10.01.2006 19:02 :

> Hi Jérôme
>
> (hooray for the compose key ;)
>
> Very minor patch attached which fixes saving some unsupported flac tags.
>
> e.g. a flac comment containing a
>   PERFORMANCE-DATE=
> tag would not be saved when updating the flac comment in Easytag since 
> the tag would mistakenly match the PERFORMER= tag.
> Similar issues with
>  COMPOSER=
>  COPYRIGHT=
>  LICENSE=     (en_US, grr :P)
>  ENCODED-BY=
>
> Applies to clean 1.99.11
>
> ciao
>    Mark
>
>
>
>
> ------------------------------------------------------------------------
>
> --- easytag-1.99.11/src/flac_tag.c.orig	2005-12-08 23:01:14.000000000 +0000
> +++ easytag-1.99.11/src/flac_tag.c	2006-01-10 17:10:23.000000000 +0000
> @@ -569,11 +569,11 @@
>           && strncasecmp((gchar *)field->entry,"TRACKTOTAL=",  MIN(11, field->length)) != 0
>           && strncasecmp((gchar *)field->entry,"GENRE=",       MIN(6,  field->length)) != 0
>           && strncasecmp((gchar *)field->entry,"DESCRIPTION=", MIN(12, field->length)) != 0
> -          && strncasecmp((gchar *)field->entry,"COMPOSER=",    MIN(6,  field->length)) != 0
> -          && strncasecmp((gchar *)field->entry,"PERFORMER=",   MIN(6,  field->length)) != 0
> -          && strncasecmp((gchar *)field->entry,"COPYRIGHT=",   MIN(6,  field->length)) != 0
> -          && strncasecmp((gchar *)field->entry,"LICENSE=",     MIN(6,  field->length)) != 0
> -          && strncasecmp((gchar *)field->entry,"ENCODED-BY=",  MIN(6,  field->length)) != 0 )
> +          && strncasecmp((gchar *)field->entry,"COMPOSER=",    MIN(9,  field->length)) != 0
> +          && strncasecmp((gchar *)field->entry,"PERFORMER=",   MIN(10,  field->length)) != 0
> +          && strncasecmp((gchar *)field->entry,"COPYRIGHT=",   MIN(10,  field->length)) != 0
> +          && strncasecmp((gchar *)field->entry,"LICENSE=",     MIN(8,  field->length)) != 0
> +          && strncasecmp((gchar *)field->entry,"ENCODED-BY=",  MIN(11,  field->length)) != 0 )
>         {
>             //g_print("custom %*s\n", field->length, field->entry);
>             FileTag->other = g_list_append(FileTag->other,g_strndup(field->entry, field->length));
>  

--
EasyTAG - Tag editor for MP3 and Ogg Vorbis files
http://easytag.sourceforge.net
--
Jerome COUDERC <easytag gmail com>