Re: Feedback on gnome-devel-demos/3.14/guitar-tuner.js.page

[David King <amigadave amigadave com>]

Hi Jose

On 2014-12-17 22:16, Jose Carlos Gonzalez <jocagovi gmail com> wrote:
> While running the sample code I ran in to the following error:
>
> (gjs:12833): Gjs-WARNING **: JS ERROR: TypeError:
> Gst.ElementFactory.make is not a constructor
> playSound  /guitar-tuner.js:29
> @./guitar-tuner.js:45
> @./guitar-tuner.js:74
>
> the offending lines
>
>  var source = new Gst.ElementFactory.make("audiotestsrc","source");
>
> var sink = new Gst.ElementFactory.make("autoaudiosink","output");
>
> the "new" keyword should not be used

Thanks again for the feedback! I fixed this and pushed a patch to 
master:

https://git.gnome.org/browse/gnome-devel-docs/commit/?id=63df6d251fd3fb9226ac207198e5238b2f33efa8

--
http://amigadave.com/

Attachment: signature.asc
Description: Digital signature