crash with my patch...

[George Georgalis <george galis org>]

Hi -

I've been happy with my patch to increase size of object handles and connection points. However, I discovered if I group two objects then grab a resize handle, the grouping disappears. If I then select all and zoom to fit, crash.

My patch (attached) changes:

  irenderer->draw_pixel_line (renderer,
                        x-CP_SZ,y-CP_SZ,
                        x+CP_SZ,y+CP_SZ,
                        color);

  irenderer->draw_pixel_line (renderer,
                        x+CP_SZ,y-CP_SZ,
                        x-CP_SZ,y+CP_SZ,
                        color);

in ./app/connectionpoint_ops.c to

  irenderer->fill_pixel_rect(renderer,
                        x - CONNECTIONPOINT_SIZE/2 + 1,
                        y - CONNECTIONPOINT_SIZE/2 + 1,
                        CONNECTIONPOINT_SIZE-2, CONNECTIONPOINT_SIZE-2,
                        color);

  irenderer->draw_pixel_rect(renderer,
                        x - CONNECTIONPOINT_SIZE/2,
                        y - CONNECTIONPOINT_SIZE/2,
                        CONNECTIONPOINT_SIZE-1, CONNECTIONPOINT_SIZE-1,
                        &color_white);

Also HANDLE_SIZE and CONNECTIONPOINT_SIZE are changed to 9.

I think the crash has something to do with float vs int values, but I cannot find what made me concerned about that before... is there any compile switches that will help me detect type mismatch? Could the issue be something else?

-George

--
George Georgalis, (415) 894-2710, http://www.galis.org/