Re: thanks for nothing - a look at the uninstaller

[Steffen Macke <dia diagramr biz>]

Hello Christophe,

On 01/30/2014 07:30 PM, Christophe Ponsard wrote:
> https://git.gnome.org/browse/dia/tree/installer/win32/dia.nsi
Unless you've build the installer yourself, this is not the installer 
source.
Please have a look at
https://git.gnome.org/browse/dia/tree/installer/win32/dia.nsi?h=dia-0-97
instead.
> there seems to be a recursive rm loop in the uninstall part
Yes, secured by an explicit warning dialog.
> note the uninstall directory is shown at the first step of uninstall 
> (but could be missed)
> later the uninstaller asks for confirmation for directory removal
> however at this stage the files are already deleted so I miss the 
> point of this check
If you look to the uninstall process in a little bit more detail, you'll 
see that the uninstallation
is performed in two stages: First the list of files from the 
installation log is deleted.
Then the user is asked, if he would like to delete the installation 
directory and all of it's contents
(in some cases there are some artifacts like temporary files or files 
from previous installations in it).
Only after confirmation from the user, the directory and its contents 
removed.

Regards,

Steffen