Re: Patch for a new feature : sozi



Hi

Here is a new version of the sozi patch. It's almost done, and you can try it 
(http://paul.chavent.free.fr/sozi.html)

On 08/06/2011 05:02 PM, Hans Breuer wrote:
I would like to submit you a patch for adding "Sozi" (http://sozi.baierouge.fr/wiki/en:welcome)
to dia. This tool is a bit like Prezi.

This is certainly an interesting concept. The names sound a bit strange, though, see: 
http://de.wikipedia.org/wiki/Sozi ;)

I don't understand German... what does it mean ?

This patch adds a "Presentation" sheet, and a "Sozi frame" object. The frame allow to
define the views of a presentation.

For a single object I think an own sheet is a bit overkill, at least I would have added it to the Misc sheet.

Done.

After trying your patch I think the frame sizing should be restricted to something which also can be 
reflected in the presentation. Possibly a rotateable rectangle as in the Inkscape tutorial [1] or a maybe a 
trapezoid if you want to support skewing.

Done. The frame shape is a rectangle.

The Sozi-Frame would be the first object actually modifying it's output dependent on the renderer. In 
prinziple I find this a bit suspicious conceptually, but maybe a dedicated export filter would indeed be less 
appropriate. Need to think about it.

Yes it's a bit annoying.
But before spreading the sozi code everywhere in the dia source tree, i preferred to make all in one place 
for the patch submission.
I will be able to change this if the patch is merged in the main source tree.

It depends on the usability and maintainability. I'm a bit uncertain if Dia's own support for transformations 
isn't a bit too weak to make something really pretty.
Although my playing with your initial version and render-test.dia already looks promising (although lacking 
rotations ;-))

This new version allow rotations and the framing is bugless this time.

To be acceptable it has to compile with more than just gcc. These are the
two things which made trying out your patch a bit long-winded for me.

sozi-script.h(45) : error C2026: string too big, trailing characters truncated

See: http://msdn.microsoft.com/en-us/library/dddywwsc%28v=vs.71%29.aspx

But even if the compiler would have accepted it, IMO 16K of JavaScript
on a single line is just not maintainable. Maybe the script should just
stay an external file and be merged during serialization?

Yes, i have some discussion with sozi maintainers for better sozi player code distribution.
So, this is a temporary solution.

sozi-frame.c(321) : error C2065: '__PRETTY_FUNCTION__' : undeclared identifier

Be careful with gcc specific extension. For the given one there is
G_STRFUNC to make it portable.

Removed.

For consistent rendering you have to set not only the line width, but also the style properties. Otherwise 
your Sozi frame's line style depends on the style of the previously drawn object. And that depends on the 
redraw
algorithm for interactive renderers.

Done.

For usability you should probably render some of the info of the Sozi-Frame, e.g. sequence number and frame 
timeout would be handy.

Yes, it's a lot more user-friendly.
Note : i join a little patch for allowing edition of text properties.

And maybe the frame rendering should be restricted to interactive renderers?

Quickly done. But it can still be improved.

Thanks for the patch, I'm looking forward to the next version ;-)

I await the mailing list feedback :)


Paul.

Attachment: 0001-Add-text-properties-widget.patch
Description: Text document

Attachment: 0002-Add-sozi-front-end.patch
Description: Text document



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]