Re: Patch for Delete key behavior (for dia-0.96.1) - save/load accels

[Lars Clausen <lars raeder dk>]

On Tue, 2007-09-25 at 20:52 +0200, Ondrej Mikle wrote:
> Hans Breuer wrote:
> > A patch to fix the broken user editable shortcuts should give you the same
> > workaround but not break the use of Delete for diagram editing for other
> > users. It would have a much bigger chance for inclusion.
>
> I send a patch that makes the saving and loading of accel keys work. The
> accel keys are stored in the old menurc file ($HOME/.dia/menurc), but
> the file has different format (the glib key-file -
> http://library.gnome.org/devel/glib/2.12/glib-Key-value-file-parser.html),
> perhaps you may wish to change the name of the file.

Thank you.  I tried the patch, and it appears to work.  However, even
without the patch, if I just remove the ; before a line, it also works,
so I a) can't tell if your patch works better or not, and b) don't see
the reason to change the format to something less standard that requires
our code to do special parsing of something that there exists a parser
for.

I believe having the ; for the unchanged bindings makes it easier to see
which ones are default and which are user-changed.  It is too bad that
gtk_accel_map_save doesn't allow a header that explains this.

I also don't see how your patch fixes the original problem:

> Also, menus_init() (at app/menus.c:465, where ~/.dia/menurc shortcuts
> are set up) is called before menus_initialize_updatable_items
> (app/menus.c:768), which makes Dia ditch all user-chosen settings in
> the
> menurc file.

You haven't moved this call with your patch, AFAICT.

-Lars