Re: Unused DiaObject::edit_text() - remove or implement?

[Lars Clausen <lars raeder dk>]

On Sun, 2007-10-07 at 12:26 +0200, Hans Breuer wrote:
> While reviewing the patch for http://bugzilla.gnome.org/show_bug.cgi?id=60331
> I stumbled about TextEditFunc added 2,5 years ago
> http://svn.gnome.org/viewcvs/dia/trunk/lib/object.h?r1=3029&r2=3028&pathrev=3029
> but not implmented/used until now. (BTW: this was our most recent DiaObject
> vtable change :))
>
> Something like this would IMO be needed to properly implement the recently
> discussed text editd mode (
> http://mail.gnome.org/archives/dia-list/2007-September/msg00097.html )
> although the signature may need to be adapted.
>
> It is not mentioned in the http://live.gnome.org/Dia/CurrentDevelopment
> yet, so maybe the plan is to not implement this on the object level?
>
> So should it be removed removed or implemented?

One of the intended uses is to let UML stuff be entered directly in the
diagram -- by letting the object know when editing starts and ends, it
can do things like putting <<>> around the text when it's not being
edited. It can also let text fields limit the characters allowed or
check syntax.  I just haven't gotten around to using it in any text yet,
nor adding it to text edit guts -- mostly because those guts have had a
lot of fixing coming to them for a while.

-Lars