Re: Request for approval: Non-uniform scaling (a.k.a. subshapes) patch

["Marcel Toele" <dpy dia gmail com>]

2007/11/24, Lars Clausen <lars raeder dk>:

I tested your patch against 3861 with the sample shape you provided, but
it worked just like any other shape, the star in the corner scaled just
as much as the box.

-Lars

I just couldn't believe my eyes when I read that. So on my home laptop, a linux box (which is running pclinuxos2007, note: the patch was prepared on debian nelly/testing) that hasn't ever seen my patch or a dia devel dir before, I did an svn check out (which was still at 3861) and subsequent build (I even had to install intltool for that):

   svn co http://svn.gnome.org/svn/dia/trunk dia
   cd dia
   zcat /tmp/subshape_for_dia_svn_rev3861.patch.gz | patch -p0
   ./autogen.sh
( report came out with all extras set to: no )
   make
   cd ~
   tar xvfz /tmp/subshape_for_dia_demo_shapes_and_sheets.tgz
   cd -
   ./app/run_dia.sh

* The first time I started dia, I got some graphic weirdness with a non-filled shape, with only an outline star drawn at the top-right corner. This was rather odd behaviour, but the subshape stayed with a proper scale.
* Then I started vanilla dia 0.95-1, which showed my shape with uniform scaling (i.e. not what you want), but filled the shape properly.
* Following this, I restarted my svn built and this time the graphic weirdness was gone and the shape performed as demonstrated in the video.
* Then I rebooted my whole machine and started the dia again from the svn build dir and it still worked, without graphic glitches and with working subshape/subscaling.

So apart from the first-time-start graphic weirdness that I cannot explain and cannot reproduce, the subshape/subscale patch works fine here on a never-before-used-for-dia-development laptop with a simple svn checkout and applying the provided patch files.

I am clueless as to why it doesn't work for you, is anyone else having the same problems with my patch?


Any suggestions as to how to proceed will be much appreciated.


cheers,

Marcel