Re: inconsistency in PROP_TYPE macro declarations ...



On Mon, 2007-04-23 at 15:55 +0530, Sameer Sahasrabuddhe wrote:
Hi,

I just noticed a problem caused by changes in lib/properties.h, made
in revision 3668:

http://svn.gnome.org/viewcvs/dia/trunk/lib/properties.h?r1=3431&r2=3668

When the property types were changed from PROP_TYPE_REAL to something
else, that broke the PropOffset data structures in some objects such
as objects/standard/line.c

As a result, properties like line_width and text_height do not get set
in do_set_props_from_offsets(). Are there other properties that were
redefined like this? All their users need to be updated so that the
corresponding PropOffset structures use the correct macros.

It was done as part of introducing units, so any kind of length or
width.  I guess I forgot the ones that are induced by the macros, while
the ones that were explicitly defined like data_lwidth in chronoline.c
and corner_radius in box.c were fixed correctly.

-Lars




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]