Re: GtkAction, Plugins and PyGtk

["Robert Staudinger" <robert staudinger gmail com>]

On 5/14/06, Hans Breuer <hans breuer org> wrote:
[...]
> Some general remarks, more detailed patch review following.
>
> - Apparently you are using a tab width of 4 while 8 is commonly used

If anyone could point me to a description of dia's coding style i'd
happily adhere to that ("gtk", "gnome", ...?). The most recent patch
uses a width of 8 in some places but it was almost done when your mail
arrived.

> - Maybe you could do the new development in some new files like
>    app/dia-actions.[hc] to improve the readability of the patches
>    and finally have better separation of functionalities than before?

Thought i'd only change the code structure where it made sense to make
the patch more readable. Most of the changes are only replacing the
deprecated GtkItemFactoryEntry stuff with its GtkUIManager/GtkAction
counterparts.
Maybe some refactoring of the relevant parts could be done when
implementing toolbars on top of the GtkAction framework.

Best,
Rob