Re: chinese support glitches?

[Lars Clausen <lars raeder dk>]

On Sun, 2004-03-07 at 08:24, Kouhei Sutou wrote:

> I have a patch that makes dia accept key states but I don't
> know this patch for which affects others. I'll attach this
> patch, so you can try it at your own risk if you want :-P.
>
> ______________________________________________________________________
> Index: app/disp_callbacks.c
> ===================================================================
> RCS file: /cvs/gnome/dia/app/disp_callbacks.c,v
> retrieving revision 1.74
> diff -u -p -r1.74 disp_callbacks.c
> --- app/disp_callbacks.c      18 Feb 2004 14:35:21 -0000      1.74
> +++ app/disp_callbacks.c      7 Mar 2004 06:49:39 -0000
> @@ -643,8 +643,7 @@ ddisplay_canvas_events (GtkWidget *canva
>          key_handled = FALSE;
>  
>          focus = active_focus();
> -        if ((focus != NULL) &&
> -            !(state & (GDK_CONTROL_MASK | GDK_MOD1_MASK)) ) {
> +        if (focus != NULL) {
>                /* Keys goes to the active focus. */
>            obj = focus->obj;
>            if (diagram_is_selected(ddisp->diagram, obj)) {

This patch breaks the ability to use Ctrl-arrowkey to scroll around the
diagram while editing, or Ctrl-{kp+,kp-} to zoom in and out while
editing.  Not good.

-Lars