RE: printing on the Simpl. Chinese and other non-latin1 loc ales



Young, Robert wrote:
Zhang Lin-bo wrote:

BTW, I have found out the bug in the freetype support:

With freetype support enabled, the fonts listed in 'font_data'
are ignored (see the '#ifdef' line at font.c:904, and I don't know
if this is a bug or a feature). Since rh7.3 uses xfs, no 
fontpath will
be found through the 'XGetFontPath' function. The patch of 
Robert Young
did not work because there was a bug in his code in parsing the
fs/config file: most path names (in my system) were skipped because
they have a trailing comma (and also I think the code needs to be
rewritten to correctly retrieve fontpaths from the 'catalogue = ...'
entry of the fs/config file (or one can borrow some lines from xfs,
or simply run the 'chkfontpath' program?)).

Ahaa, thank you - the first feedback on my patch. Yes, stupid 
me didn't
remove the trailing commas. Sorry.
Because the freetype code that Lars wrote is nice and doesn't 
mind being
passed paths which do not contain fonts, I passed anything 
that looked like
a path from the xfs config file to the 
freetype_scan_directory and then let
it decide whether there are fonts there. 
Yes, detecting the "catalogue = ..." line would be sensible - 
this patch was
a first cut which won't crash, it just might end up checking 
lots of other
places for fonts...
I did look at the chkfontpath source as chkfontpath is a RH 
specific program
- I will clean up my code and resubmit.

Please note that this issue is covered in
http://bugzilla.gnome.org/show_bug.cgi?id=83098

Feel free to offer more suggestions. I'll try and have a new 
patch attached
to this bug later today (Australian time).


New patch available - see latest attachment to
http://bugzilla.gnome.org/show_bug.cgi?id=83098

I'm reasonably happy that it fixes the above issues.

Please test, let me know if there are any issues. If everyone's happy, is it
able
to be merged for 0.90?

Regards,
Rob.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]