Re: Diagram tree window - patch (Was: Re: xml-i18n and a new feature)



Cyrille Chepelov <chepelov calixo net> writes:

Le mer, oct 31, 2001, à 01:18:43 +0100, Jose A. Ortega Ruiz a écrit:

the attached patch (to be applied to the current CVS tree) implements
the diagram window idea i mentioned a few days ago:

unfortunately, it lacks diagtree.h, which makes it uncompilable.


oops! it was a stale reference to an old file, sorry. the new patch
should compile without it


I'm going to whine a little over form, but this is really because I can't
whine over the rest:

      * there are a few changes of blank lines (some appear, some
disappear). It would be nice if the patch didn't include these.


i've tried to remove them and think it's ok now

      * GPL copyright header in the new files is OK ; however, there are
not-totally-trivial modifications to other files. To the letter compliance
means adding a modification notice to each file, but of course practice just
asks for a ChangeLog entry (mentioning all places you touched).


the new patch includes ChangeLog entries for all the changes. please,
let me know if they are detailed enough...

      * there is no character-level handling, thus I think it's UTF-8
safe.
      * I see nothing which could prevent that code from running on
Win32, but I'm no Win32-gtk expert. Hans ?
 
      * this stuff looks really cool, I'm impatient to try it out.


thanks. i hope this new patch lets you try it out :-) 

btw, you will notice that the diagram tree window has a horizontal
scrollbar much wider than the actual tree width (the vertical one
looks ok): i've not been able to reduce this width: any ideas? (i've
used scrolled windows without problems in the past, but via libglade).

thank you very much for your comments.

regards,

jao

Attachment: dia.diff.gz
Description: dia diff



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]