Re: Bug report for 0.88.1 - resize & fig export

[Lars Clausen <lrclause cs uiuc edu>]

On Tue, 17 Jul 2001, Cris Bailiff wrote:

> I can't find any on-line bug reporting system, so I'm mailing to the
> list:
>
> * As reported here recently, dia 0.88.1 can't resize shapes with
> internal text (other than by editting the text). My example is the
> 'cloud' from the network sheet, which only sizes to fit the enclosing
> text. Bit hard to draw the whole internet with a cloud thats smaller
> than every other icon.
>
> * Export to fig format has troubles (I accept its experimental):
> * Colour definitions are incorrectly formatted in the output file, so
> fig rejects them and all images come out all black. The hex strings
> appear to be loosing the required zero padding - I have
>
> '0 33 #0ff0'
>
> instead of (I assume)
> '0 33 #000ff0'
>
> and likewise for colour 34:
> '0 34 #ffff0'
>
> which I made
> '0 34 #ffff00'

This is easily fixed:

Index: plug-ins/xfig/xfig-export.c
===================================================================
RCS file: /cvs/gnome/dia/plug-ins/xfig/xfig-export.c,v
retrieving revision 1.1
diff -u -r1.1 xfig-export.c
--- plug-ins/xfig/xfig-export.c 2001/05/08 21:17:09     1.1
+++ plug-ins/xfig/xfig-export.c 2001/07/17 15:53:42
@@ -195,7 +195,7 @@
     return;
   }
   renderer->user_colors[renderer->max_user_color] = *color;
-  fprintf(renderer->file, "0 %d #%x%x%x\n", renderer->max_user_color+32,
+  fprintf(renderer->file, "0 %d #%02x%02x%02x\n", renderer->max_user_color+32,
          (int)(color->red*255), (int)(color->green*255), (int)(color->blue*255));
   renderer->max_user_color++;
 }


> * Colour definitions need to be first in the file (before objects). I
> moved the '0 xx' lines to the top of my sample, and fig stopped
> complaining.

This is more nasty -- it means I'll have to either make two passes or store
most output in a string.  Two passes sounds like the right thing to do.

> * I still have a bunch of complaints about ploygons with fewer than 3
> points - again, possibly missing zeros, but I'm not sure on this one.

This is more odd -- which objects give that?

> Promising start - I'd love to have dia do really good fig export (and
> import too?)

Import is more difficult, as Dia is not really set up for import.  Better
export will be possible when we have the more advanced grouping system
we've discussed earlier, which will let shapes appear as groups in Fig.

-Lars

-- 
Lars Clausen (http://shasta.cs.uiuc.edu/~lrclause) | Hårdgrim of Numenor
"I do not agree with a word that you say, but I    | Retainer of Sir Kegg
will defend to the death your right to say it."    |   of Westfield
    --Evelyn Beatrice Hall paraphrasing Voltaire   | Chaos Berserker of Khorne