Re: -Werror considered harmful

[Colin Walters <walters verbum org>]

On Tue, 2013-02-26 at 15:03 +0100, Dieter Verfaillie wrote:
> On 2013-02-26 14:20, Maciej Piechotka wrote:
> > I would be for not including -Werror inside configure.ac at all and
> > trust people with commit rights to enable it (either by explicit 
> > option
> > or by CFLAGS variable).
>
> Agreed, especially since autoconf supports site default values,
> where maintainers can set configuration values to just about
> anything as crazy as they like (including CFLAGS), without forcing
> the craziness on users via configure.ac

Note we're not talking about -Werror.  We're talking about a more
carefully hand-selected subset of compiler warnings intended to act as a
"baseline".  

I don't believe the baseline approach is "craziness", and I am
definitely interested in willing to discuss improvements, and will work
on patches (like the one posted).

The problem with the "opt in" approach is then everyone who uses jhbuild
to contribute to GNOME will basically not be opted in, and it's far too
easy for them to write patches that fail the baseline.