Re: -Werror considered harmful

[Colin Walters <walters verbum org>]

Hi Behdad,

At a high level, please keep in mind that you're working with a
distributed group of people across the Internet who are actually trying
to make the world a better place (for some loosely-aligned definition of
"better").

Adding the warnings turned up a large variety of bugs in GLib, and
has been quite beneficial.  I'm sorry it broke for you, but please
remember I'm not here to break things, so there's no need to start with
the the "<rant>" approach.

On Tue, 2013-02-26 at 09:19 +0100, Dan Winship wrote:
> On 02/26/2013 02:39 AM, Behdad Esfahbod wrote:
> > In file included from ../../../glib/libcharset/localcharset.c:28:
> > /usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/include/stdio.h:372:
> > error: no previous prototype for 'getc'
>
> This is a bug in whatever version of mingw you are using;
> -Wmissing-prototypes is not supposed to apply to system headers.

And for reference, I did test building glib with mingw32 when landing
the warning patch, and it still builds here (currently Fedora 18 x86_64
with the packaged mingw32-* cross tools).

That said, I think we can do something here to help people who have
buggy toolchains, but don't care and just want some binaries.  

I filed a patch here:

https://bugzilla.gnome.org/show_bug.cgi?id=694757