Re: libxml2 commit 65c7d3b2e6506283eecd19a23dcf0122fbcdac33

[Daniel Veillard <veillard redhat com>]

On Mon, Aug 13, 2012 at 09:34:14AM +0800, Daniel Veillard wrote:
> On Sun, Aug 12, 2012 at 02:37:52PM +0200, Stef Walter wrote:
[...]
> > Daniel, do you have a patch for gnome-online-accounts? It seems that its
> > build fails due to this commit:
> > 
> > make[2]: Entering directory
> > `/data/src/jhbuild/gnome-online-accounts/src/goabackend'
> >   CC       libgoa_backend_1_0_la-goaewsclient.lo
> > goaewsclient.c: In function 'ews_client_post_restarted_cb':
> > goaewsclient.c:354:49: error: dereferencing pointer to incomplete type
> > goaewsclient.c:355:39: error: dereferencing pointer to incomplete type
> > goaewsclient.c: In function 'ews_client_create_msg_for_url':
> > goaewsclient.c:371:54: error: dereferencing pointer to incomplete type
> > goaewsclient.c:372:44: error: dereferencing pointer to incomplete type
> > make[2]: *** [libgoa_backend_1_0_la-goaewsclient.lo] Error 1
> > make[2]: Leaving directory
> > `/data/src/jhbuild/gnome-online-accounts/src/goabackend'
> > 
> > Line 354 is:
> > 
> > (gchar *) buf->buffer->content,
> 
>   Humpf, for some reason I can't clone gnome git right now [*]
> 
> thinkpad:~ -> git clone
> ssh://veillard git gnome org/git/gnome-online-accountsCloning into
> 'gnome-online-accounts'...
> ssh: connect to host git.gnome.org port 22: Connection timed out
> fatal: The remote end hung up unexpectedly
> thinkpad:~ ->
> 
>   otherwise I would have given a patch, but I assume the pattern is that
> you are using buf->buffer->content on one line and buf->buffer->use
> on the next line in two blocks starting at lines 354 and 371. In that
> case the patch would be very similar to the one for
> evolution-data-server,

  For the record, your patch:

  http://git.gnome.org/browse/gnome-online-accounts/commit/?id=1afba9aa98436551db4c3589eed943f49a106293

  looks just fine to me !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/